https://bugzilla.redhat.com/show_bug.cgi?id=994474 --- Comment #10 from Michael Schwendt <bugs.michael@xxxxxxx> --- Spec URL: http://git.scrit.ch/srpm/python-qrencode/plain/SPECS/python-qrencode.spec SRPM URL: http://scrit.ch/assets/python-qrencode-1.01-1.fc19.src.rpm Let's see also what "fedora-review -b 994474" will find. It evaluates those two "Spec URL:" and "SRPM URL:" lines. [...] > %attr(0755, -, -) %{python_sitearch}/qrencode/qr_encode.so Not in the guidelines. Just a hint/recommendation: It's okay to use %attr for settings _ordinary_ permissions like that, but better not get used to it. Prefer "chmod" in the %install section, or get it fixed directly in the upstream tarball (e.g. using "install -m0755 …"). In packages with many more files, if you needed to "fix" permissions, overusing %attr would reduce readability a lot. 0755 and 0644 are too common. Restrict usage of %attr to setting really special/unusual permissions (e.g. setuid, setgid, g-rx) and owner/group changes, so special attributes set with %attr really stick out (especially when using syntax highlighting). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6Ff8iwOTex&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review