Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: bootparamd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225623 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ruben@xxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-03-18 08:30 EST ------- Needs work: * Package does not follow Fedora's package naming guildlines (wiki: PackageNamingGuidelines) * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Encoding should be UTF-8 * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets) * Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets) Rpmlint is not silent: Source RPM: W: bootparamd summary-ended-with-dot A server process which provides boot information to diskless clients. E: bootparamd tag-not-utf8 %changelog W: bootparamd no-url-tag W: bootparamd strange-permission bootparamd.init 0775 E: bootparamd non-utf8-spec-file bootparamd.spec W: bootparamd prereq-use /sbin/chkconfig /etc/init.d E: bootparamd use-of-RPM_SOURCE_DIR W: bootparamd mixed-use-of-spaces-and-tabs (spaces: line 49, tab: line 1) rpmlint of bootparamd: W: bootparamd summary-ended-with-dot A server process which provides boot information to diskless clients. E: bootparamd tag-not-utf8 %changelog W: bootparamd no-url-tag W: bootparamd conffile-without-noreplace-flag /etc/rc.d/init.d/bootparamd E: bootparamd executable-marked-as-config-file /etc/rc.d/init.d/bootparamd -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review