https://bugzilla.redhat.com/show_bug.cgi?id=977132 --- Comment #3 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to Jamie Nguyen from comment #2) > Oh yes, I was going to ask your advice about this package. > > I've actually deleted all of the minified JS in the %prep section, so as it > stands there's no precompiled JS. Please add some comments clearly indicating the minified code has been removed and that this is the only thing that would be build by the disabled %build section. It wasn't immediately obvious to me that this was the only problem. With everything explained properly, I should be able to approve this. > But of course the minified scripts are > fairly important so it's less than ideal to have a package without them. Are they just there for the browser? > The ideal thing to do is package google-closure-compiler and fix the build > script to stop fetching external sources, but I'm not sure that's something > I can get done within a reasonable time frame (particularly based on the > comments from the Red Hat Satellite bugzilla). But of course if that's the > only option, then that's the path I will take... I looked at this. The Rhino issue Stanislav mentioned two years ago [1] is still very much a problem. :-( > Would it be acceptable to minimize them differently than is done in the > build scripts? For example, minify with just uglify-js and be done with it? > That might result in poorer compression etc, but I'd guess that the end > result for the user mostly won't be noticeable. If they're just needed for the browser, I'd suggest omitting them at this time. I intend to propose real honest-to-God client-side JavaScript guidelines and a corresponding F20 Feature/Change/whatever in mid-July, and whatever ends up being hashed out with FPC should provide guidance with this and many other gotchas. Who knows, we might even work out a compromise that allows the preminified scripts. (Fat chance, but one can dream. ;-) uglify-js and coffee-script currently aren't shipping minified JS either so this is definitely something I want to fix, I'd just rather do so in a way that is future-proof. [1] https://bugzilla.redhat.com/show_bug.cgi?id=725739#c4 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZP073P1hjJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review