https://bugzilla.redhat.com/show_bug.cgi?id=977132 --- Comment #4 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- (In reply to T.C. Hollingsworth from comment #3) > Please add some comments clearly indicating the minified code has been > removed and that this is the only thing that would be build by the disabled > %build section. It wasn't immediately obvious to me that this was the only > problem. > > With everything explained properly, I should be able to approve this. Ah, sorry, my fault. I got lazy :( > > But of course the minified scripts are > > fairly important so it's less than ideal to have a package without them. > > Are they just there for the browser? Yes, only for the browser. The module is still useful without the minified scripts. > I looked at this. The Rhino issue Stanislav mentioned two years ago [1] is > still very much a problem. :-( :( > If they're just needed for the browser, I'd suggest omitting them at this > time. I intend to propose real honest-to-God client-side JavaScript > guidelines and a corresponding F20 Feature/Change/whatever in mid-July, and > whatever ends up being hashed out with FPC should provide guidance with this > and many other gotchas. Who knows, we might even work out a compromise that > allows the preminified scripts. (Fat chance, but one can dream. ;-) Heh, one can indeed dream ;) > uglify-js and coffee-script currently aren't shipping minified JS either so > this is definitely something I want to fix, I'd just rather do so in a way > that is future-proof. Agreed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhV1vPhnZj&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review