[Bug 977132] Review Request: nodejs-lodash - A low-level utility library delivering consistency and customization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=977132

--- Comment #2 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
Oh yes, I was going to ask your advice about this package.

I've actually deleted all of the minified JS in the %prep section, so as it
stands there's no precompiled JS. But of course the minified scripts are fairly
important so it's less than ideal to have a package without them.

The ideal thing to do is package google-closure-compiler and fix the build
script to stop fetching external sources, but I'm not sure that's something I
can get done within a reasonable time frame (particularly based on the comments
from the Red Hat Satellite bugzilla). But of course if that's the only option,
then that's the path I will take...

Would it be acceptable to minimize them differently than is done in the build
scripts? For example, minify with just uglify-js and be done with it? That
might result in poorer compression etc, but I'd guess that the end result for
the user mostly won't be noticeable.

Thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VNw8GVBPpF&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]