https://bugzilla.redhat.com/show_bug.cgi?id=975339 Jan Pazdziora <jpazdziora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpazdziora@xxxxxxxxxx --- Comment #3 from Jan Pazdziora <jpazdziora@xxxxxxxxxx> --- (In reply to Vít Ondruch from comment #2) > * Test suite > - Is there any feasible way how to run a test suite of this package? I don't think so. The setup needed would be pretty complex (you need Kerberos server and stuff). > * License should be included in main package > - Please move "%doc %{gem_instdir}/COPYING" into the main package [1]. Fixed. > * Do not mark everything in -doc subpackage by %doc macro > - examples, test and Rakefile should not be marked as %doc, since they are > not documentation IMO Fixed. > * rpmlint > - There used to be bug in gem2rpm which results in this warning: > > ./rubygem-gssapi.spec:48: W: macro-in-comment %gem_dir > > Please escape the macro > - There is useless line commented out which produces following rpmlint > warnings: > > ./rubygem-gssapi.spec:56: W: macro-in-comment %{buildroot} > ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_instdir} > ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_name} > ./rubygem-gssapi.spec:56: W: macro-in-comment %{buildroot} > ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_spec} > > Please remove this line. Fixed. Patch --- rubygem-gssapi.spec.2013-06-18 2013-06-18 07:18:10.811000440 +0000 +++ rubygem-gssapi.spec 2013-06-20 12:03:04.267000530 +0000 @@ -45,7 +45,7 @@ # Create the gem as gem install only works on a gem file gem build %{gem_name}.gemspec -# %%gem_install compiles any C extensions and installs the gem into ./%gem_dir +# %%gem_install compiles any C extensions and installs the gem into ./%%gem_dir # by default, so that we can move it into the buildroot in %%install %gem_install @@ -53,7 +53,6 @@ mkdir -p %{buildroot}%{gem_dir} cp -pa .%{gem_dir}/* \ %{buildroot}%{gem_dir}/ -# mv %{buildroot}%{gem_instdir}/%{gem_name}.gemspec %{buildroot}%{gem_spec} rm -f %{buildroot}%{gem_instdir}/%{gem_name}.gemspec @@ -62,17 +61,17 @@ %{gem_libdir} %exclude %{gem_cache} %{gem_spec} +%doc %{gem_instdir}/COPYING %files doc %doc %{gem_docdir} %doc %{gem_instdir}/README.textile -%doc %{gem_instdir}/COPYING -%doc %{gem_instdir}/VERSION -%doc %{gem_instdir}/examples -%doc %{gem_instdir}/test -%doc %{gem_instdir}/Rakefile +%{gem_instdir}/VERSION +%{gem_instdir}/examples +%{gem_instdir}/test +%{gem_instdir}/Rakefile %doc %{gem_instdir}/preamble %changelog -* Mon Jun 17 2013 root - 1.1.2-1 +* Mon Jun 20 2013 Jan Pazdziora - 1.1.2-1 - Initial package applied to the .spec file. New .spec file is at http://adelton.fedorapeople.org/rubygem-gssapi.spec and the new .src.rpm is at http://kojipkgs.fedoraproject.org//work/tasks/3696/5523696/rubygem-gssapi-1.1.2-1.fc19.src.rpm > Otherwise, the package look quite OK. Please fix the issues so I can approve > it. Thanks. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tmM4oCYzxZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review