https://bugzilla.redhat.com/show_bug.cgi?id=975339 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Jan Pazdziora from comment #3) > (In reply to Vít Ondruch from comment #2) > > * Test suite > > - Is there any feasible way how to run a test suite of this package? > > I don't think so. The setup needed would be pretty complex (you need > Kerberos server and stuff). OK, np ... but it would be nice if you could somehow document it in the .spec file, for future reference. > applied to the .spec file. New .spec file is at Thanks. I have two additional remarks: * Wrong changelog format - According to [1], I am missing your email in changelog. * Release bump - Although not mandatory, it is nice to bump release for each review cycle. It makes easier to check the differences between SRPM of each iteration. Since these are just minor nits, I APPROVE the package. Nevertheless, please fix the changelog prior importing the package into Fedora (of course no point in bumping release now, but you can make me happier next time ;) [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CuqBvtdWxn&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review