https://bugzilla.redhat.com/show_bug.cgi?id=975339 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Test suite - Is there any feasible way how to run a test suite of this package? * License should be included in main package - Please move "%doc %{gem_instdir}/COPYING" into the main package [1]. * Do not mark everything in -doc subpackage by %doc macro - examples, test and Rakefile should not be marked as %doc, since they are not documentation IMO * rpmlint - There used to be bug in gem2rpm which results in this warning: ./rubygem-gssapi.spec:48: W: macro-in-comment %gem_dir Please escape the macro - There is useless line commented out which produces following rpmlint warnings: ./rubygem-gssapi.spec:56: W: macro-in-comment %{buildroot} ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_instdir} ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_name} ./rubygem-gssapi.spec:56: W: macro-in-comment %{buildroot} ./rubygem-gssapi.spec:56: W: macro-in-comment %{gem_spec} Please remove this line. Otherwise, the package look quite OK. Please fix the issues so I can approve it. Thanks. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IkcEMpxk2n&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review