[Bug 967403] Review Request: python-tvrage - Python client for the tvrage.com XML API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=967403

--- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to Mario Blättermann from comment #1)
> python-devel in BR is deprecated, use python2-devel:
> https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

Fixed.

> Actually you are packaging a fully versioned tarball, but in particular you
> are using a VCS checkout. Somewhat strange that a developer a kind of
> "rolling release" this way... The release tag has to reflect this issue. See
> for more information (and to get a proper upgrade path):
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

Is it a problem? I don't think so, the author has tagged it as 0.4.1 so I think
we don't need to care about it's from when and where.

> Just ran rpmlint on your spec:
> 
> rpmlint -i -v *
> python-tvrage.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
> line 9)

Fixed.

> python-tvrage.spec: I: checking-url
> https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.
> tar.gz (timeout 10 seconds)

Your internet problem.

> There are some testing scripts in the "tests" subfolder, is it possible to
> run them (in a %check section)?

Fixed.

NEW Spec URL: http://cicku.me/python-tvrage.spec
NEW SRPM URL: http://cicku.me/python-tvrage-0.4.1-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5TteVLsMbv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]