https://bugzilla.redhat.com/show_bug.cgi?id=967403 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- python-devel in BR is deprecated, use python2-devel: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires Actually you are packaging a fully versioned tarball, but in particular you are using a VCS checkout. Somewhat strange that a developer a kind of "rolling release" this way... The release tag has to reflect this issue. See for more information (and to get a proper upgrade path): http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Just ran rpmlint on your spec: rpmlint -i -v * python-tvrage.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 9) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-tvrage.spec: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. There are some testing scripts in the "tests" subfolder, is it possible to run them (in a %check section)? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oLM3GiQxIS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review