Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957422 --- Comment #9 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to comment #6) > Short pre-review: > > = Errors = > * Remove gcc-c++ from BR: Fixed(But in fact I haven't installed it yet before building it, I've groupinstall development tools) > * Source0: double // Oh, Fixed. > * %doc: images/ not used anywhere It's used by manuals, why should it be removed? After running the program I don't see a builtin manuals. > * licensecheck errors (incorrect FSF address) Where? I've compared with gpl.txt and found everything is same. Or did I missed something? > * PREFIX=%{_bindir} is not used. No. If it's nothing the program will be installed to /usr/local/bin which is even worser. > > = Issues = > * Koji builds for target distros. Later. > * change *-devel to pkgconfig(*) where it is possible (pkgconfig(QtGui), > pkgconfig(aspell), pkgconfig(hunspell), pkgconfig(libpng)). Why?(Not very understand) > * src.pro does not provides "make release". > What's make release? > Now I want to explore bundled quazip, zlib, zip/unzip. Not bundled I think. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xbAV6CD2V9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review