Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957422 --- Comment #10 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- (In reply to comment #9) > Fixed(But in fact I haven't installed it yet before building it, I've > groupinstall development tools) I know. But this is rule :-( > > * licensecheck errors (incorrect FSF address) > > Where? I've compared with gpl.txt and found everything is same. http://www.fsf.org/about/contact/ is right address. > > * PREFIX=%{_bindir} is not used. > > No. If it's nothing the program will be installed to /usr/local/bin which is > even worser. And what is it? "install -p -D -m 755 bin/%{name} %{buildroot}%{_bindir}/%{name}" > > * change *-devel to pkgconfig(*) where it is possible (pkgconfig(QtGui), > > pkgconfig(aspell), pkgconfig(hunspell), pkgconfig(libpng)). > > Why?(Not very understand) This is issue - not bug. Using pkgconfig() make spec "packagename-independent". You don't know how these packages will be named in next Fedora release or EL. > > * src.pro does not provides "make release". > What's make release? "Make release" provides compiling without debug information. "Make debug" - with it. Just add "CONFIG += debug_and_release" to src.pro This is issue too - not a bug. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FGdiAGyCPL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review