Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=738465 --- Comment #9 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Thanks for the update. * LICENSE file must be included in the main package. - See [1] for more information * Include test suite as a SOURCE - I am afraid, that build of your package fails on Koji. You cannot donwload/checkout anything from the internet. Please follow the guidelines, which gives example how to properly include test suite [2] * Run the test suite from .%{gem_instdir} - If you run the test suite from .%{gem_instdir}, you will save some hassle with moving and deleting the test suite. * Move into -doc subpackage non-essential files %{gem_instdir}/DESCRIPTION %{gem_instdir}/Gemfile %{gem_instdir}/Gemfile.lock %{gem_instdir}/Rakefile %{gem_instdir}/barista.gemspec - The files above should do to -doc subpackage, since they are not needed for runtime. * Exclude the hidden files %{gem_instdir}/.document %{gem_instdir}/.rspec %{gem_instdir}/.rvmrc.example - The above files should be exclude (I guess rpmlint would warn about them). I suggest to use "%exclude %{gem_instdir}/.*" to exclude them all in once. * The package is not buildable - Apparently, you are not BR: git, which you are using later. But since you are going to redo the %check section it should not be issue, just something to be aware. - In the future, please use mock [3] for local testing or Koji [4] (which is for bonus points ;) [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text [2] https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package [3] https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds [4] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DPrAKnhfKm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review