Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to comment #1) > Hi Ankur, I was just about to package this, but you've done it for me! I'll > be happy to help with the review. What are you doing with this? I want it > for PyCAM (also in review). The pybrain package recommends using pyode :) > > Quick drive-by before the real review: > > - This URL may help with the 'W: invalid-url' problem > https://downloads.sourceforge.net/project/pyode/pyode/snapshot-2010-03-22/ > PyODE-snapshot-2010-03-22.tar.gz Thanks. Updated. > > - If you remove execute permissions from ode.so, you won't have to bother > with the '%{?filter_setup:...' business. (Why do you set them in %install?) To get rid of this rpmlint error: pyode.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/ode.so 0775L The permissions must be correct, and since it's an internally used shared object, it must be removed from provides. > > - Nitpick: %description lacking a trailing '.'. Corrected > > - Nitpick: (I was dinged for this on my last pkg) Double spaces before > %description, %prep, %build, etc. make the specfile more readable. I don't think this is required. The spec is readable enough :) > > - The %files section really does need blank lines to separate it from the > %install script. Added. > > - Those comments about the tests might be more clear if they were prefaced > with a line like this that indicates they're the reason for not running > tests, despite the existence of a 'tests' directory: > #%%check Added phony check section line. [ankur@localhost SRPMS]$ rpmlint ../SPECS/pyode.spec ./pyode-1.2.0-2.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm pyode.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. [ankur@localhost SRPMS]$ New spec/srpm: http://ankursinha.fedorapeople.org/pyode/pyode.spec http://ankursinha.fedorapeople.org/pyode/pyode-1.2.0-2.fc20.src.rpm Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mPXvYVrRK9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review