Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 John Morris <john@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |john@xxxxxxxxxxx --- Comment #1 from John Morris <john@xxxxxxxxxxx> --- Hi Ankur, I was just about to package this, but you've done it for me! I'll be happy to help with the review. What are you doing with this? I want it for PyCAM (also in review). Quick drive-by before the real review: - This URL may help with the 'W: invalid-url' problem https://downloads.sourceforge.net/project/pyode/pyode/snapshot-2010-03-22/PyODE-snapshot-2010-03-22.tar.gz - If you remove execute permissions from ode.so, you won't have to bother with the '%{?filter_setup:...' business. (Why do you set them in %install?) - Nitpick: %description lacking a trailing '.'. - Nitpick: (I was dinged for this on my last pkg) Double spaces before %description, %prep, %build, etc. make the specfile more readable. - The %files section really does need blank lines to separate it from the %install script. - Those comments about the tests might be more clear if they were prefaced with a line like this that indicates they're the reason for not running tests, despite the existence of a 'tests' directory: #%%check -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Edpcs4oy2s&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review