Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #3 from John Morris <john@xxxxxxxxxxx> --- > > - If you remove execute permissions from ode.so, you won't have to bother > > with the '%{?filter_setup:...' business. (Why do you set them in %install?) > > To get rid of this rpmlint error: > pyode.x86_64: E: non-standard-executable-perm > /usr/lib64/python2.7/site-packages/ode.so 0775L > > The permissions must be correct, and since it's an internally used shared > object, it must be removed from provides. Hmm, I learned something new. For regular packages containing modules, if the module perms are set 0644, the filter_provides_in macro ignores them. Not so with python modules. > > - Nitpick: (I was dinged for this on my last pkg) Double spaces before > > %description, %prep, %build, etc. make the specfile more readable. > > I don't think this is required. The spec is readable enough :) Sure. > > - Those comments about the tests might be more clear if they were prefaced > > with a line like this that indicates they're the reason for not running > > tests, despite the existence of a 'tests' directory: > > #%%check > Added phony check section line. I'm addressing %check differently in the review. Stay tuned... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qer9rN90nq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review