Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #24 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #21) > Sure. Could you please CC me on the ticket? Sure. > Thanks for making all the changes and providing the patch. Given all these > complexities and testing effort, I'm inclined to focus on Fedora 18+ and > RHEL 7+, because those are almost the same from systemd perspective. That > will help me keep the SPEC file simple and testing is easy for me. Hope you > would agree with me? I can test and I'm offering myself as co-mantainer for the package, but I would like to have epel 5 and 6 available. Is that ok for you? I'm writing the SysV init script for RHEL now. > I looked at the bug https://bugs.kde.org/show_bug.cgi?id=190522 and it seems > to have been fixed in a way that it is not reproducible. However, I will not > be able to fix/test the note right now, because this file is coming from > open-vm-tools source and we will need to fix the source code as sourceforge. > I think we will need to raise a ticket for open-vm-tools code. In the mean time you can provide a patch for it. I would rather not apply a fix for a problem we don't know it does exist. People can always file a bug later if they have some problems running kde with the guest agent starting. From the bug report, the issue does not seem to happen since KDE 4.8. > Removed RestartSec. TimeoutStopSec default is 90s which is way too long from > service stop and guest shutdown perspectives. Please note that tools service > does not handle SIGTERM nicely, so systemd ends up timing out and issues > SIGKILL ultimately to kill this service. I believe this also needs to be > fixed in open-vm-tools source code. > I had started with "simple" service and had some issues. So, I set it to > forking, I will try again with "simple". Again, you can still patch the code and push it upstream. (In reply to comment #23) > - It looks like the help subpackage contains developement documentation. > You'd better drop it and include it in the devel subpackage. Agreed, this is api documentation and the help package is fairly small (100 kb). > - Static libraries are not recommanded to be provided: > > Unless you have a good reason to provide them, please drop them. You can use > the --disable-static option in %configure. Remove also all *.la files. Yes, please delete them. > - Be careful not to own directories already owned by other packages: the > desktop subpackage provides some desktop files in > %{_sysconfdir}/xdg/autostart/, please refer to them in « %files desktop » > section as below: > %files desktop > ... > %{_sysconfdir}/xdg/autostart/*.desktop Yes, I did not notice this, please fix it as well. > Also in devel subpackage: > %files devel > ... > %{_includedir}/vmGuestLib/ The one which is now in place works fine as well as at the moment of packaging there are no extra files in /usr/include/ except those from the package, so the folder is included. You can change as suggested here, if you prefer. > - Using %defattr(..) macro, after each %files section, is deprecated. Please > drop all of them. Isn't this needed for EPEL 5? > - Doc. files are usually installed in %{_docdir}/%{name}-%{version}. You can > probably use the --docdir=%{_defaultdocdir}/%{name}-%{version}/ option in > %configure, instead of installing API documentation « manually » through > %doc. If you can, yes, please do. > Using %exclude is also discouraged to drop files from packages. You should > remove them instead in %install section. I prefer this too, as while doing the actual building you can have a folder containing only what's needed in the package. > - The summary may be more explicit about the roles of the package: something > like « Open VMware Tools for virtual machines hosted on VMware » or whatever > may be more explicit for the main package. Yep. > - Last but not least, open-vm-tools are not usable without specific kernel > modules, unless I'm wrong. Since Fedora doesn't allow inclusion of external > kernel modules, are they plans from VMware to merge them in the vanilla > kernel? Is there a schedule or a kernel version target? So far, as far as I know, all the required drivers except for the hgfs driver for filesystem mounting are included in RHEL 6.4+ and Fedora 17+. Do not know for RHEL 5. Any info on this? Thanks Mohamed for your comments. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZFCdGSHZGI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review