Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #23 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Some comments: - It looks like the help subpackage contains developement documentation. You'd better drop it and include it in the devel subpackage. - Static libraries are not recommanded to be provided: http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 Unless you have a good reason to provide them, please drop them. You can use the --disable-static option in %configure. Remove also all *.la files. - Be careful not to own directories already owned by other packages: the desktop subpackage provides some desktop files in %{_sysconfdir}/xdg/autostart/, please refer to them in « %files desktop » section as below: %files desktop ... %{_sysconfdir}/xdg/autostart/*.desktop ... Also in devel subpackage: %files devel ... %{_includedir}/vmGuestLib/ - Using %defattr(..) macro, after each %files section, is deprecated. Please drop all of them. - Doc. files are usually installed in %{_docdir}/%{name}-%{version}. You can probably use the --docdir=%{_defaultdocdir}/%{name}-%{version}/ option in %configure, instead of installing API documentation « manually » through %doc. Using %exclude is also discouraged to drop files from packages. You should remove them instead in %install section. - The summary may be more explicit about the roles of the package: something like « Open VMware Tools for virtual machines hosted on VMware » or whatever may be more explicit for the main package. - Last but not least, open-vm-tools are not usable without specific kernel modules, unless I'm wrong. Since Fedora doesn't allow inclusion of external kernel modules, are they plans from VMware to merge them in the vanilla kernel? Is there a schedule or a kernel version target? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ANbj5kYadV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review