Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948626 Patrick Uiterwijk <puiterwijk@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Patrick Uiterwijk <puiterwijk@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License BSD OK - License field in spec matches NO - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 9d30e7826e13c31793bbad333b7434ce Flask-Mako-0.2.tar.gz 9d30e7826e13c31793bbad333b7434ce Flask-Mako-0.2.tar.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: Checking: python-flask-mako-0.2-1.fc18.noarch.rpm python-flask-mako.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python-flask-mako.noarch: W: summary-ended-with-dot C Mako templating support for Flask applications. python-flask-mako.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting 1 packages and 0 specfiles checked; 0 errors, 3 warnings. You can ignore those, if you use the spec file on your website rather than the one in the SRPM, as that one fixes the summary-ended-with-dot. This is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zOpLIdl4Aw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review