Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=950041 --- Comment #2 from Matthias Runge <mrunge@xxxxxxxxxx> --- Sadly, the build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=5236458 + chmod a+x bin/lessc + cp -rp bin package.json lib/less/browser.js lib/less/colors.js lib/less/functions.js lib/less/index.js lib/less/lessc_helper.js lib/less/parser.js lib/less/rhino.js lib/less/tree lib/less/tree.js '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch/%{nodejs_sitelib}/less' cp: target '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch/%{nodejs_sitelib}/less' is not a directory The root cause seems to be, %{nodejs_sitelib} is not defined (at least in rawhide): + mkdir -p '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch%{nodejs_sitelib}/less' According to the packaging guidelines, your code is correct. - Could you please also change the permissions on less-1.3.3.tgz? nodejs-less.src: W: strange-permission less-1.3.3.tgz 0444L I don't see this as really critical, just a non-blocking minor. Else it looks good to me. Since it's a rename, esp. obsoletes are correct to me. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CpZC4RYBF6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review