Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #16 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to comment #15) > And, I can swear I did not mix tabs and spaces :-) > > I have defined tab space=8 in my vimrc and I think you would have defined it > as 4, because your alignment in patch is not working in my VIM until I set > tab space to 4. Please let me know if space is preferred over tabs in > general. I personally prefer space because of tab weirdness, but I'd like to > follow Fedora convention for this submission. I have downloaded the file again and it contains tabs again, maybe it's a Dropbox "feature"? :D I prefer spaces as well, and there's no general guidelines for this, only to be consistent on it all over the spec file. > I think it would be great if we can get this package in FC 18 as well, > please let me know how to make that happen? We can make it happen (and I'm very interested in) for both Fedora and EPEL by making the spec file compatible with both distributions / releases. This involves a few things: - Systemd specific BuildRequires/Requires/%post for Fedora 17/18 - Systemd specific BuildRequires/Requires/%post for Fedora 19 and RHEL/CentOS 7+ - SysV init specific BuildRequires/Requires/%post for RHEL/CentOS 5/6 - SysV init script for RHEL/CentOS 5/6 Your spec file already contains a bit of everything, in particular, the systemd policies are for Fedora 17/18, the Group directive is for RHEL/CentOS 5 only. Next set of comments in a few minutes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=blO4Z7sVKs&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review