Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #17 from Simone Caronni <negativo17@xxxxxxxxx> --- 1) Service enablement According to the Fedora policies no service should be started upon installation for the exception of those listed in this page: https://fedoraproject.org/wiki/Starting_services_by_default I agree that the guestd daemon should be started upon installation as this is installed only in VMWare guests. After the review I will file a ticket to FESCO as required, to see if we can enable it: https://fedorahosted.org/fesco/ So for now _all_ services should be installed but disabled by default. 2) Systemd conditionals To enable Systemd for Fedora 17 and 18+, we need to apply the packaging policies as defined here: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd As you see, there are differences between those 2 blocks (18+ and 17) so an "%if" between distributions should be applied When f17 will be EOL, the block relevant to it can be removed. 3) RHEL/CentOS 5 building RHEL/CentOS 5 has rpm 4.5 and needs some more settings for packages. A BuildRoot, and a %clean section. To generate template spec files for the various distributions, use the "rpmdev-newspec" command. For example, the following 3 commands: rpmdev-newspec -m -r 4.5 -o 45.spec rpmdev-newspec -m -r 4.8 -o 48.spec rpmdev-newspec -m -o 410.spec 4) SysV init script conditionals SysV init scripts for RHEL/CentOS systems is defined in these policies: https://fedoraproject.org/wiki/Packaging:SysVInitScript Again we need to "%if" the distribution from Fedora. You can create a SysV init script template with the "rpmdev-newinit open-vm-tools-guestd" command from the "rpmdevtools" package. Please create it, modify appropriately for RHEL and add it to the source package as "open-vm-tools-guestd.init"; it's the commented line with "Source2". All the information you need is in the above link. The init script should be enabled by default on runlevels 2-5 when "chkconfig --enable" is run; as the tools can be handy also in single user mode. will generate rpm spec file templates for RHEL 5 (rpm 4.5), RHEL 6 (rpm 4.8) and Fedora 18+. You can tie the version to the generation, for example Fedora 19 uses rpm 4.11 (no changes to the template). 5) open-vm-tools-desktop The file "/etc/xdg/autostart/vmware-user.desktop" contains a note about KDE, can you check that this is still valid? 6) open-vm-tools-guestd.service Please see the following URL: http://fedoraproject.org/wiki/Packaging:Systemd - The Documentation directive is missing - The lines "RestartSec=5" and "TimeoutStopSec=2" are probably not needed, as the process is contained in a cgroup - Daemons should not be forking if possible, they should "stay" in the foreground as systemd takes care of that. Can the "Type=forking" line be removed? - Probably you can make the description like "Service for virtual machines hosted on VMware" and remove the package name from it, but this is not required. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IBH8HI2VOg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review