Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=905255 --- Comment #15 from Ravindra Kumar <ravindrakumar@xxxxxxxxxx> --- Simone, thanks for the review and providing a fixes patch. I have incorporated your patch as is and made a few corrections in the files section for base and devel packages. Please find the updated files below. SPEC File URL: https://www.dropbox.com/s/bfv10xe5hnxsvor/open-vm-tools.spec SRPM URL: https://www.dropbox.com/s/nyga3zs6xilazhl/open-vm-tools-9.2.2-3.fc18.src.rpm And, I can swear I did not mix tabs and spaces :-) I have defined tab space=8 in my vimrc and I think you would have defined it as 4, because your alignment in patch is not working in my VIM until I set tab space to 4. Please let me know if space is preferred over tabs in general. I personally prefer space because of tab weirdness, but I'd like to follow Fedora convention for this submission. I think it would be great if we can get this package in FC 18 as well, please let me know how to make that happen? Looking forward for the next set of comments! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Me8Lq7QY04&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review