Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=865977 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> --- A few questions about some changes in the updates: > %files > %defattr(-,root,root,-) > -%doc README NEWS COPYING ChangeLog > -%{_libdir}/*.so.* > -%{_datadir}/* > +%doc README NEWS COPYING > +%{_libdir}/libsigrokdecode.so.0* > +%{_datadir}/libsigrokdecode/* /usr/share/libsigrokdecode/ is not included now: https://fedoraproject.org/wiki/Packaging:UnownedDirectories > $ rpmls -p libsigrokdecode-devel-0.1.1-1.fc18.x86_64.rpm |grep inc > -rw-r--r-- /usr/include/sigrokdecode.h The header includes Python.h which is a missing dependency in the -devel package. > # Combined GPLv3+ and GPLv2+ > License: GPLv3+ Some of the C source files are GPLv2+, others are GPLv3+, some Python based decoders are pure GPLv2+ and installed as such. License clarification would be good here, because the binary package clearly contains files, which are GPLv2+ licensed, and I think one cannot implicitly upgrade the licensing to GPLv3+. * https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification * https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario * https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#GPL_Compatibility_Matrix > make %{?_smp_mflags} V=1 make %{?_smp_mflags} and the build output would be more verbose and .e.g. show what compiler flags are used. > %files > %doc README NEWS COPYING > %files devel > %doc README Not sure why the README file is duplicated. It doesn't add any convenience, but just creates a separate docdir for the -devel package and for just this file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=me2irwFjUf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review