Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=865977 --- Comment #5 from Alex G. <mr.nuke.me@xxxxxxxxx> --- (In reply to comment #4) > A few questions about some changes in the updates: > > > %files > > %defattr(-,root,root,-) > > -%doc README NEWS COPYING ChangeLog > > -%{_libdir}/*.so.* > > -%{_datadir}/* > > +%doc README NEWS COPYING > > +%{_libdir}/libsigrokdecode.so.0* > > +%{_datadir}/libsigrokdecode/* > > /usr/share/libsigrokdecode/ is not included now: > https://fedoraproject.org/wiki/Packaging:UnownedDirectories > Fixed. Tanks! > > $ rpmls -p libsigrokdecode-devel-0.1.1-1.fc18.x86_64.rpm |grep inc > > -rw-r--r-- /usr/include/sigrokdecode.h > > The header includes Python.h which is a missing dependency in the -devel > package. > Fixed. Tanks! > > # Combined GPLv3+ and GPLv2+ > > License: GPLv3+ > > Some of the C source files are GPLv2+, others are GPLv3+, some Python based > decoders are pure GPLv2+ and installed as such. License clarification would > be good here, because the binary package clearly contains files, which are > GPLv2+ licensed, and I think one cannot implicitly upgrade the licensing to > GPLv3+. > I've contacted upstream, and they updated the README file. I've cherry-picked the commit as a patch. > > make %{?_smp_mflags} > > V=1 make %{?_smp_mflags} and the build output would be more verbose and > .e.g. show what compiler flags are used. > I'm not sure if you mean "V=1" should be permanently in the spec file, or just temporary, for testing. compile flags: -DHAVE_CONFIG_H -I. -I/usr/include/python3.2mu -I/usr/include/python3.2mu -DDECODERS_DIR='"/usr/share/libsigrokdecode/decoders"' -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -Wextra -fvisibility=hidden -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -c link flags: -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -Wextra -fvisibility=hidden -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -version-info 0:1:0 -lpthread -ldl -lutil -lm -lpython3.2mu -Xlinker -export-dynamic -Wl,-z,relro -o libsigrokdecode.la -rpath /usr/lib64 -lglib-2.0 It looks like %{optflags} is respected. > > > %files > > %doc README NEWS COPYING > > > %files devel > > %doc README > > Not sure why the README file is duplicated. It doesn't add any convenience, > but just creates a separate docdir for the -devel package and for just this > file. Fixed. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yubTMLrwAr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review