Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906481 --- Comment #5 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Thanks for your new version. I retested with the fedora-review tool, and all mentioned points are fixed now, but I found a few new issues: The fedora-review tool now gives these extra items: [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in erlang- cowboy-doc ==>the doc package contains example scripts that will only run if the base package is installed I think. Therefore the doc package should have a fully versioned Requires for the base package. Please add this. [!]: License file installed when any subpackage combination is installed. ==>this automatically will be the case if the above Require is added [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. ==>no longer an issue with this version Rpmlint ------- Checking: erlang-cowboy-0.8.2-2.fc18.x86_64.rpm erlang-cowboy-doc-0.8.2-2.fc18.noarch.rpm erlang-cowboy.x86_64: E: no-binary erlang-cowboy.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. ==>this is no problem. The no-binary thing is a known erlang 'feature'. See for example the discussion in comment 2 of bug #906473 Rpmlint (installed packages) ---------------------------- # rpmlint erlang-cowboy erlang-cowboy-doc erlang-cowboy.x86_64: E: no-binary erlang-cowboy.x86_64: W: only-non-binary-in-usr-lib erlang-cowboy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/erlang-cowboy-0.8.2/examples/websocket/priv/static/jquery.min.js 2 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' ==>this one still complains about the line ending issue It's not clear to me why. Requires -------- ... erlang-cowboy-doc (rpmlib, GLIBC filtered): /bin/sh Because of the above rpmlint issue I looked at the content of this file jquery.min.js and this one seems to have been downloaded from another project: http://blog.jquery.com/2012/08/09/jquery-1-8-released/ According to: http://jquery.com/download/ the license for this file is MIT or GPL clearly this needs to be added to the License field of the spec file, probably with a comment referring to the file in question. looking at: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Bundling_of_multiple_projects I feel a bit uneasy allowing this into the doc package, but a quick locate shows more projects provide copies of this file: >locate jquery.min /usr/lib/python2.7/site-packages/django/contrib/admin/static/admin/js/jquery.min.js /usr/share/transmission/web/javascript/jquery/jquery.min.js /var/lib/mock/fedora-18-x86_64/root/usr/share/doc/erlang-cowboy-0.8.2/examples/websocket/priv/static/jquery.min.js The python-django package is BSD licensed and includes jquery version 1.4.2 which also is dual licensed MIT and GPLv2. No explanation is given in the spec file, so this seems not correct to me. The transmission-common package refers in its specfile to the COPYING file in which it is clearly stated that the package combines elements that are MIT licensed and elements that are GPLv2 licensed. This package includes jquery version 1.7.2 which also is dual licensed MIT and GPLv2. I also noted that in this bug #857992 a discussion occurs on the packaging of jquery in other packages. It seems here that the discussion on unbundling them is still ongoing. Concluding, because it is clear the jquery code in this erlang-cowboy is part of the example documentation, I will not reject your package because of it, but would feel more comfortable if you would just remove this particular example from the doc package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rcUMPzt91x&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review