Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915144 --- Comment #8 from Antonio Trande <trpost@xxxxxxxxxxxx> --- (In reply to comment #7) > > > - Package consistently uses macro is (instead of hard-coded directory names). > > %%{name} macro can be used more frequently in .spec file. > > May be. Not sure. > Hardcoded system dir names are not present. 'install -D -m 755 %{SOURCE4} %{buildroot}%{_bindir}/rasmol' becomes 'install -D -m 755 %{SOURCE4} %{buildroot}%{_bindir}/%{name}' or 'cp data/* %{buildroot}%{_datadir}/rasmol/data/' becomes 'cp data/* %{buildroot}%{_datadir}/%{name}/data/' or again 'Patch1: rasmol-2.7.5-23Jul09-gtk.patch' becomes 'Patch1: %{name}-2.7.5-23Jul09-gtk.patch' > > > - update-desktop-database is invoked when required > > Note: desktop file(s) in rasmol, rasmol-gtk > > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > Icon cache updated in rasmol package, no more icons for rasmol-gtk. > http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file- > install_usage was used for .desktop files. > Again, what is wrong? Probably it refers to missing icon in gtk sub-package but indicated by grasmol.desktop file. I'm not sure. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GZj0Y8ppNC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review