Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915144 --- Comment #7 from Dmitrij S. Kryzhevich <krege@xxxxxxx> --- Spec URL: http://krege.fedorapeople.org/rasmol/rasmol.spec SRPM URL: http://krege.fedorapeople.org/rasmol/rasmol-2.7.5-4.fc18.src.rpm Thanks. > - gzip can be omitted Done. > - Another license (LGPLv2+) has been detected for 'eggfileformatchooser.h' > file. You should consider to add a multiple licensing: Right. Missed that. > - Patches link to upstream bugs/comments/lists or are otherwise justified. > These info are missing, add them if possible. Didn't catch that. Add comment on pathes but bot sure it is what you mean. > - Package uses nothing in %doc for runtime. > -doc sub-package contains '%{_datadir}/%{name}/data' directory with all > *.pdb* files; .pdb files are Protein Data Bank data files used from > application. > Why they are excluded from main package ? If they were not, -doc sub-package > could be packaged as 'noarch' and could contain only document files. noarch added. data dir is a dir with examples, their are not needed for rasmol to work actualy. > - Fully versioned dependency in subpackages, if present. > I don't know if Epochs is strictly necessary for rasmol; if no, > 'Requires: %{name}%{?_isa} = %{version}-%{release}' is better. Why not? Fixed. > - Package consistently uses macro is (instead of hard-coded directory names). > %%{name} macro can be used more frequently in .spec file. May be. Not sure. Hardcoded system dir names are not present. > - rasmol-doc.x86_64: W: file-not-utf8 > /usr/share/doc/rasmol-doc-2.7.5/doc/itrasmol2721.hlp > This warning seems can be fixed by using something like that: > > iconv --from=ISO-8859-1 --to=UTF-8 doc/itrasmol2721.hlp > > doc/itrasmol2721_new.hlp > mv doc/itrasmol2721_new.hlp doc/itrasmol2721.hlp ISO-8859-1? How could I gues that... > - update-desktop-database is invoked when required > Note: desktop file(s) in rasmol, rasmol-gtk > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Icon cache updated in rasmol package, no more icons for rasmol-gtk. http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage was used for .desktop files. Again, what is wrong? > rasmol.x86_64: E: incorrect-fsf-address /usr/share/doc/rasmol-2.7.5/GPL This is semipositive issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yN2mpWLpeF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review