Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915144 Antonio Trande <trpost@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trpost@xxxxxxxxxxxx --- Comment #6 from Antonio Trande <trpost@xxxxxxxxxxxx> --- Hi Dmitrij. I'm not a official Fedora packager so let me try to review your package. My review could contain some (my) evaluation errors, please you consider all that as a test for myself. :) - gzip can be omitted https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2 - Another license (LGPLv2+) has been detected for 'eggfileformatchooser.h' file. You should consider to add a multiple licensing: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios - Patches link to upstream bugs/comments/lists or are otherwise justified. These info are missing, add them if possible. - Package uses nothing in %doc for runtime. -doc sub-package contains '%{_datadir}/%{name}/data' directory with all *.pdb* files; .pdb files are Protein Data Bank data files used from application. Why they are excluded from main package ? If they were not, -doc sub-package could be packaged as 'noarch' and could contain only document files. - Fully versioned dependency in subpackages, if present. I don't know if Epochs is strictly necessary for rasmol; if no, 'Requires: %{name}%{?_isa} = %{version}-%{release}' is better. - Package consistently uses macro is (instead of hard-coded directory names). %%{name} macro can be used more frequently in .spec file. - rasmol-doc.x86_64: W: file-not-utf8 /usr/share/doc/rasmol-doc-2.7.5/doc/itrasmol2721.hlp This warning seems can be fixed by using something like that: iconv --from=ISO-8859-1 --to=UTF-8 doc/itrasmol2721.hlp > doc/itrasmol2721_new.hlp mv doc/itrasmol2721_new.hlp doc/itrasmol2721.hlp http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gzip See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - update-desktop-database is invoked when required Note: desktop file(s) in rasmol, rasmol-gtk See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rasmol-gtk , rasmol-doc [x]: Package complies to the Packaging Guidelines [?]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/sagitter/rpmbuild/SRPMS/915144-rasmol/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in rasmol [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 481280 bytes in 20 files. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6676480 bytes in /usr/share 10240 rasmol-gtk-2.7.5-3.fc16.x86_64.rpm 5744640 rasmol- doc-2.7.5-3.fc16.x86_64.rpm 921600 rasmol-2.7.5-3.fc16.x86_64.rpm [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rasmol-2.7.5-3.fc16.x86_64.rpm rasmol-gtk-2.7.5-3.fc16.x86_64.rpm rasmol-doc-2.7.5-3.fc16.x86_64.rpm rasmol.x86_64: W: manual-page-warning /usr/share/man/man1/rasmol.1x.gz 1: warning: macro `PU' not defined rasmol.x86_64: W: manual-page-warning /usr/share/man/man1/rasmol.1x.gz 4119: warning: macro `false',' not defined rasmol.x86_64: E: incorrect-fsf-address /usr/share/doc/rasmol-2.7.5/GPL rasmol.x86_64: W: no-manual-page-for-binary rasmolb rasmol-gtk.x86_64: W: no-documentation rasmol-gtk.x86_64: W: no-manual-page-for-binary grasmol rasmol-doc.x86_64: W: file-not-utf8 /usr/share/doc/rasmol-doc-2.7.5/doc/itrasmol2721.hlp 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rasmol-doc rasmol-gtk rasmol rasmol-doc.x86_64: I: enchant-dictionary-not-found en_US rasmol-doc.x86_64: W: file-not-utf8 /usr/share/doc/rasmol-doc-2.7.5/doc/itrasmol2721.hlp rasmol-gtk.x86_64: W: no-documentation rasmol-gtk.x86_64: W: no-manual-page-for-binary grasmol rasmol.x86_64: W: manual-page-warning /usr/share/man/man1/rasmol.1x.gz 1: warning: macro `PU' not defined rasmol.x86_64: W: manual-page-warning /usr/share/man/man1/rasmol.1x.gz 4119: warning: macro `false',' not defined rasmol.x86_64: E: incorrect-fsf-address /usr/share/doc/rasmol-2.7.5/GPL rasmol.x86_64: W: no-manual-page-for-binary rasmolb 3 packages and 0 specfiles checked; 1 errors, 6 warnings. # echo 'rpmlint-done:' Requires -------- rasmol-doc (rpmlib, GLIBC filtered): rasmol rasmol-gtk (rpmlib, GLIBC filtered): /bin/sh libCNearTree.so.5()(64bit) libCQRlib.so.2()(64bit) libCVector-1.0.3.so.2()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcbf.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libvte.so.9()(64bit) rasmol rtld(GNU_HASH) rasmol (rpmlib, GLIBC filtered): /bin/sh libCNearTree.so.5()(64bit) libCQRlib.so.2()(64bit) libCVector-1.0.3.so.2()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libXpm.so.4()(64bit) libc.so.6()(64bit) libcbf.so.0()(64bit) libforms.so.2()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xterm Provides -------- rasmol-doc: rasmol-doc rasmol-doc(x86-64) rasmol-gtk: rasmol-gtk rasmol-gtk(x86-64) rasmol: rasmol rasmol(x86-64) MD5-sum check ------------- http://www.rasmol.org/software/RasMol_2.7.5.tar.gz : CHECKSUM(SHA256) this package : aa7e7fd4b3c074e67697bd6adf7e86b9a4c60b605f5a319d6ecdd144b39f7fe9 CHECKSUM(SHA256) upstream package : aa7e7fd4b3c074e67697bd6adf7e86b9a4c60b605f5a319d6ecdd144b39f7fe9 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-16-x86_64 Command line :/usr/bin/fedora-review -b 915144 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7OhZOSt9N3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review