Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919469 --- Comment #2 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- Why did you patch the upstream code? The first part (configure.ac) is only cosmetics in my eyes. And patching mate-applet-softupd.spec.in is useless because you use your own spec for building the rpm. mate-applet-softupd.spec.in is for building a rpm directly from the tar ball. The package builds fine without patching it. If you don't have another serious reason for using the patch, please remove them. @ your spec file 1. remove %global pixmapdir %{_datadir}/pixmaps %global iconsdir %{_datadir}/icons %global localedir %{_datadir}/locale configure choose those paths withhout setting global defines by hand. 2. Why you use 'rm -rf m4' and create them new? And if you want to do this you can simply use autoreconf -i -f to create the *.m4 files new. 3. Using BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is obsolete, you don't need it anymore. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 4. remove rm -rf "${RPM_BUILD_ROOT}" from install section, this obsolete for the same reason. 5. change make %{?_smp_mflags} CFLAGS="${CFLAGS}" to make %{?_smp_mflags} https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make In result you have to change make install DESTDIR="${RPM_BUILD_ROOT}" to make install DESTDIR=$RPM_BUILD_ROOT and rm -rf "${RPM_BUILD_ROOT}%{_docdir}" to rm -rf $RPM_BUILD_ROOT%{_docdir} 6. pls use macros for find langugage. %find_lang %{name} and %files -f %{name}.lang https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files 7. pls use valid rpm scriptlets for the icon cache https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache %post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : 8. using a clean section is obsolete, pls remove them. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 9. using %defattr(-, root, root, -) is obsolete if you don't want to build for EPEL5, pls remove. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions 10. pls remove all those lines in the spec file. #------------------------------------------------------------------------------- I know your spec file is based from Assen's one, but this is a personal format style and shoudn't use for fedora. https://fedoraproject.org/wiki/Packaging:Guidelines#Writing_a_package_from_scratch Ok, that's all for the moment :) , pls upload a new spec file and SRPM version. Than i can use the review-tool and rpmlint. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zw16CnMxMq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review