Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919469 --- Comment #3 from Patrick Monnerat <pm@xxxxxxxxxxxxx> --- > The first part (configure.ac) is only cosmetics in my eyes. No it isn't. It fixes an error that occurs only if no backend is found. However I agree this is most unlikely to occur in our case. > If you don't have another serious reason for using the patch, please remove them. Yes, it also adds a missing french translation. The patch is a post-0.2.5 adjustment that has been transmitted upstream and accepted as a whole. That's why it includes fixes to the upstream spec file. I agree we don't need the whole patch: if it really disturbs you, I can make a patch that only deals with configure.ac and the missing french string. > 1. remove Done > 2. Why you use 'rm -rf m4' and create them new? Since I have to autoconf (because of configure.ac change), I prefer to use system macros that are in phase with the autoconf version. And yes, I have replaced the whole auto-things by autoreconf as you suggest. > 3. Using BuildRoot ... is obsolete Removed I hope it will also be obsolete in EPEL whenever this package (and Mate) will hit it: although I do not plan to deal with EPEL myself, I welcome comaintainers for that platform and I like to ease their work and unify the spec file when possible. > 4. remove rm -rf "${RPM_BUILD_ROOT}" from install section Done Same EPEL remark > 5. change make %{?_smp_mflags} CFLAGS="${CFLAGS}" ... Done: this was remaining from the time this package did not use automake. > 6. pls use macros for find langugage. Done > 7. pls use valid rpm scriptlets for the icon cache Done, although they were perfectly valid, even if not matching guideline characters one to one. About quoting: you made me remove quoting everywhere. I did it but I do not agree: this weakens the spec file in case the substituted macro/shellvar value ever contains a shell special character. > 8. using a clean section is obsolete Done. See EPEL remark. > 9. using %defattr(-, root, root, -) is obsolete Removed > 10. pls remove all those lines in the spec file. Done, although I find it much less readable. > pls upload a new spec file and SRPM version. SPEC URL: http://monnerat.fedorapeople.org/mate-applet-softupd.spec SRPM URL: http://monnerat.fedorapeople.org/mate-applet-softupd-0.2.5-2.fc18.src.rpm Thanks for your work! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dECYxCE9V0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review