Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919469 --- Comment #4 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to comment #3) > > The first part (configure.ac) is only cosmetics in my eyes. > No it isn't. It fixes an error that occurs only if no backend is found. > However I agree this is most unlikely to occur in our case. agree > > If you don't have another serious reason for using the patch, please remove them. > Yes, it also adds a missing french translation. > The patch is a post-0.2.5 adjustment that has been transmitted upstream and > accepted as a whole. That's why it includes fixes to the upstream spec file. > I agree we don't need the whole patch: if it really disturbs you, I can make > a patch that only deals with configure.ac and the missing french string. You have to update you tarball, as Assen told me this morning the french translation is include in 0.2.5. (org.mate.applets.SoftupdApplet.mate-panel-applet.in) I'm still wondering why he doesn't fix the typo in configure.ac, maybe he needs a reminder. > > 1. remove > Done > > > 2. Why you use 'rm -rf m4' and create them new? > Since I have to autoconf (because of configure.ac change), I prefer to use > system macros that are in phase with the autoconf version. agree in this case I forgot to say you don't need BR automake, it will be already called by autoconf. But you can change this later. Review results comming soon. PS: my irc nickname is raveit65 on fedora and mate channels -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QATMMf7IxZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review