Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iverilog - Icarus Verilg is a verilog compiler, simulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229657 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-27 03:38 EST ------- here we go with the :SHOULD: part from http://fedoraproject.org/wiki/Packaging/ReviewGuidelines. Conventions for below: OK = it's OK as it is MUSTFIX = there is a problem which needs fixing NA = not available/ does not apply If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it - OK The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available - NA The reviewer should test that the package builds in mock. - OK, builds in mock for devel/x86_64 - SHOULD: The package should compile and build into binary rpms on all supported architectures - OK, builds in mock for devel/x86_64 and i386 (no ppc to test on) - SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example - OK, works as advertised - SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. - NA - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. - OK - SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. - NA There are no blockers so the package is APPROVED. Cristi, unless someone spots something that I have missed (I hope I did not...), you can proceed with CVS request. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review