Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iverilog - Icarus Verilg is a verilog compiler, simulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229657 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2007-02-27 05:59 EST ------- Thanks Christian for pushing electronics applications in Fedora. I maintain the geda suite. Perhaps we might work together to push more and more electronic apps inside. #001 I've seen during the %install /usr/bin/install -c -m . You should preserve timestamps. %{__make} prefix=%{buildroot}%{_prefix} \ bindir=%{buildroot}%{_bindir} \ libdir=%{buildroot}%{_libdir} \ libdir64=%{buildroot}%{_libdir} \ includedir=%{buildroot}%{_includedir} \ mandir=%{buildroot}%{_mandir} \ vpidir=%{buildroot}%{_libdir}/ivl/ \ INSTALL="install -p" install #002 The tarball is mal-packaged. It ships an autom4te.cache/. I'd suggest to rm -rf autom4te.cache in %prep You can delete them by %{__rm} -rf autom4te.cache for f in cadpli driver driver-vpi examples ivlpp libveriuser solaris tgt-fpga \ tgt-null tgt-pal tgt-stub tgt-verilog tgt-vvp vpi vpip vvm vvp; do pushd $f %{__rm} -rf autom4te.cache popd done #003 You shouldn't ship %{_libdir}/*.a in the -devel package Delete them %{__rm} -f %{buildroot}%{_libdir}/{libveriuser,libvpi}.a #004 # WARNING !!! # %{?_smp_mflags} broken Can you explain in one/two line (in the spec file) why it's broken? #005 I disagree on how %{version} has been filled. "iverilog -v" shows: Icarus Verilog version 0.9.devel ($Name: s20070123 $) You missed the 0.9.XXXXXX I'll rather opt for : %define snapshot 20070123 Name: iverilog Version: 0.9.0.%{snapshot} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review