Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913152 --- Comment #5 from Antonio Trande <trpost@xxxxxxxxxxxx> --- Hi Paulo. Thank you for cooperation. I'm dedicated myself to the Make* files insomuch as I've forgotten all that in evidence. :P (In reply to comment #4) > Since this package intersects with your ipopt, and my > coin-or-Ipopt review request, I did a simple review > request: > > > ================================ > MUST: > > 1. %build honors applicable compiler flags or justifies otherwise. > Build does not honor compiler flags. See "grep -r CFLAGS" and > "grep -r OPTC" in the BUILD dir. Need to either patch, or just > pass CFLAGS to make call. I've added all flags in the Make.par.inc and Make.seq.inc files directly. > > 2. Changelog in prescribed format. > Minor issue, just break the line between the 2 changelog entries. Fixed. > > 3. Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Self explanatory. Also remove the %clean section. Fixed. > > 4. Each %files section contains %defattr if rpm < 4.4 > Note: %defattr present but not needed > Remove %defattr from all %files sections. Fixed. > > 5. Development files must be in a -devel package > .so links are not in the -devel package and also should use > a relative link (target is in the same directory). Fixed. > > 6. Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/lib64/MUMPS > Self explanatory. Fixed. > > 7. If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > LICENSE file is not in %doc. > README is installed and not set as %doc. > Package is not owner of %{_docdir}/%{name}-%{version}. > Since the -seq package does not require the main package (error?) > it should also include LICENSE as %doc; I suggest making it require > the main package to also silence the warning about it not requiring > the main package... > The .ps and .pdf documentation is not installed. I suggest > "%doc doc/*.pdf" and "%doc doc/%.ps" Fixed. > > 9. Package must own all directories that it creates. > As described in 8., package is not owner of %{_docdir}/%{name}-%{version}. > > Fixed. > ================================ > SHOULD: > > 1. Buildroot is not present > Note: Buildroot: present but not needed > Just remove the > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > line. Fixed. > > 2. Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: %clean present but not required > Just remove the %clean section. Fixed. > > 3. Spec use %global instead of %define. > Note: %define __provides_exclude_from > %{_libdir}/openmpi/lib/(lib(mca|o|v)|openmpi/).*.so %define > __requires_exclude libopen.*.so > Self explanatory. Fixed. > > ================================ > EXTRA: > > 1. Please consider installing headers in /usr/include/MUMPS: > $ ls rpms-unpacked/MUMPS-devel-4.10.0-1.fc18.x86_64.rpm/usr/include/|wc -l > 14 > this may need some minor patching or adding -IMUMPS to build. Fixed. > > 2. -devel package should have: > Requires: %{name}%{?_isa} = %{version}-%{release} > instead of > Requires: %{name} = %{version}-%{release} Fixed. > > 3. Summary and description of the seq subpackage are a wrong, cut&paste > of the -devel package. Fixed. > > 4. Please make a examples subpackage with the examples subdir, verify > the README there, and validate it works. *OR* make of the examples > subdirectory a %check section. This would help a reviewer to press > "x" in the "Package functions as described" field. I've added a 'examples' sub-package that contains README and all 'simpletest' files. But it seems to exist another problem by executing them: $ ./ssimpletest < input_simpletest_real ./ssimpletest: error while loading shared libraries: libmpi_f77.so.1: cannot open shared object file: No such file or directory > > 5. You should not do > chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/?simpletest > chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/input_* > in %install. This just causes it to install ELF binary files without > executable permission just for the bogus warning > 'script-without-shebang' Fixed. > > 6. Instead of using a single mumps-extra.tar.gz tarball, You should add > it as a Patch, with the proper link to > > http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/mumps/raring/ > files/head:/debian/patches/$PATCH_NAME > and use %patch instead of calling patch in %build. At least, should > use patch in %prep (that is, to help in "without prep" partial > debug builds). > Should also give a brief description of what the patch does, and > if applicable, a link to where the patch was submitted upstream. Fixed. > > > > ============================================================================= > = > > Package Review > ============== > > Key: > [x] = Pass > [!] = Fail > [-] = Not applicable > [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > [!]: Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/lib64/MUMPS > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > > > Rpmlint (installed packages) > ---------------------------- > # rpmlint MUMPS-seq MUMPS-debuginfo MUMPS-devel MUMPS > MUMPS-seq.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libmpiseq-4.10.0.so /lib64/libm.so.6 > MUMPS-seq.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libmpiseq-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS-seq.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libmpiseq-4.10.0.so /lib64/libquadmath.so.0 > MUMPS-seq.x86_64: W: no-documentation > MUMPS-debuginfo.x86_64: E: debuginfo-without-sources > MUMPS-devel.x86_64: W: no-documentation > MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/ssimpletest > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libmpi_f77.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libmpi.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libopen-rte.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libopen-pal.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libscalapack.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libmpiblacs.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libmpiblacsF77init.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so libmpiblacsCinit.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so /lib64/libpord-4.10.0.so > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libcmumps-4.10.0.so /lib64/libquadmath.so.0 > MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libpord-4.10.0.so > exit@GLIBC_2.2.5 > MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/zsimpletest > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libmumps_common-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libmumps_common-4.10.0.so /lib64/libquadmath.so.0 > MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libmumps_common-4.10.0.so > exit@GLIBC_2.2.5 > MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/csimpletest > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libmpi_f77.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libmpi.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libopen-rte.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libopen-pal.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libscalapack.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libmpiblacs.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libmpiblacsF77init.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so libmpiblacsCinit.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so /lib64/libpord-4.10.0.so > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libdmumps-4.10.0.so /lib64/libquadmath.so.0 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libmpi_f77.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libmpi.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libopen-rte.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libopen-pal.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libscalapack.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libmpiblacs.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libmpiblacsF77init.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so libmpiblacsCinit.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so /lib64/libpord-4.10.0.so > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libzmumps-4.10.0.so /lib64/libquadmath.so.0 > MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/dsimpletest > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libmpi_f77.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libmpi.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libopen-rte.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libopen-pal.so.4 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libscalapack.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libmpiblacs.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libmpiblacsF77init.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so libmpiblacsCinit.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so /lib64/libpord-4.10.0.so > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so /lib64/libgcc_s.so.1 > MUMPS.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libsmumps-4.10.0.so /lib64/libquadmath.so.0 > 4 packages and 0 specfiles checked; 1 errors, 61 warnings. > # echo 'rpmlint-done:' > 'unused-direct-shlib-dependency' warnings seem the origin of dependency problems during installation. Sincerely, I don't know how resolve them. After a searching, it seems that the flags '-Wl --as-needed' can be useful but it seems me they do not work. Spec URL: http://sagitter.fedorapeople.org/MUMPS/MUMPS.spec SRPM URL: http://sagitter.fedorapeople.org/MUMPS/MUMPS-4.10.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QDaP114pye&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review