Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913152 Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paulo.cesar.pereira.de.andr | |ade@xxxxxxxxx --- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- Since this package intersects with your ipopt, and my coin-or-Ipopt review request, I did a simple review request: ================================ MUST: 1. %build honors applicable compiler flags or justifies otherwise. Build does not honor compiler flags. See "grep -r CFLAGS" and "grep -r OPTC" in the BUILD dir. Need to either patch, or just pass CFLAGS to make call. 2. Changelog in prescribed format. Minor issue, just break the line between the 2 changelog entries. 3. Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Self explanatory. Also remove the %clean section. 4. Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed Remove %defattr from all %files sections. 5. Development files must be in a -devel package .so links are not in the -devel package and also should use a relative link (target is in the same directory). 6. Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/MUMPS Self explanatory. 7. If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. LICENSE file is not in %doc. README is installed and not set as %doc. Package is not owner of %{_docdir}/%{name}-%{version}. Since the -seq package does not require the main package (error?) it should also include LICENSE as %doc; I suggest making it require the main package to also silence the warning about it not requiring the main package... The .ps and .pdf documentation is not installed. I suggest "%doc doc/*.pdf" and "%doc doc/%.ps" 8. License file installed when any subpackage combination is installed. See 7. 9. Package must own all directories that it creates. As described in 8., package is not owner of %{_docdir}/%{name}-%{version}. ================================ SHOULD: 1. Buildroot is not present Note: Buildroot: present but not needed Just remove the BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) line. 2. Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required Just remove the %clean section. 3. Spec use %global instead of %define. Note: %define __provides_exclude_from %{_libdir}/openmpi/lib/(lib(mca|o|v)|openmpi/).*.so %define __requires_exclude libopen.*.so Self explanatory. ================================ EXTRA: 1. Please consider installing headers in /usr/include/MUMPS: $ ls rpms-unpacked/MUMPS-devel-4.10.0-1.fc18.x86_64.rpm/usr/include/|wc -l 14 this may need some minor patching or adding -IMUMPS to build. 2. -devel package should have: Requires: %{name}%{?_isa} = %{version}-%{release} instead of Requires: %{name} = %{version}-%{release} 3. Summary and description of the seq subpackage are a wrong, cut&paste of the -devel package. 4. Please make a examples subpackage with the examples subdir, verify the README there, and validate it works. *OR* make of the examples subdirectory a %check section. This would help a reviewer to press "x" in the "Package functions as described" field. 5. You should not do chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/?simpletest chmod a-x $RPM_BUILD_ROOT%{_libdir}/%{name}/input_* in %install. This just causes it to install ELF binary files without executable permission just for the bogus warning 'script-without-shebang' 6. Instead of using a single mumps-extra.tar.gz tarball, You should add it as a Patch, with the proper link to http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/mumps/raring/files/head:/debian/patches/$PATCH_NAME and use %patch instead of calling patch in %build. At least, should use patch in %prep (that is, to help in "without prep" partial debug builds). Should also give a brief description of what the patch does, and if applicable, a link to where the patch was submitted upstream. ============================================================================== Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages [!]: Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/MUMPS See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [!]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/MUMPS [x]: Permissions on files are set properly. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package seq [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/pcpa/913152-MUMPS/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [!]: SourceX / PatchY prefixed with %{name}. Note: Source1 (mumps-extra.tar.gz) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define. Note: %define __provides_exclude_from %{_libdir}/openmpi/lib/(lib(mca|o|v)|openmpi/).*.so %define __requires_exclude libopen.*.so ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: MUMPS-devel-4.10.0-1.fc18.x86_64.rpm MUMPS-4.10.0-1.fc18.src.rpm MUMPS-debuginfo-4.10.0-1.fc18.x86_64.rpm MUMPS-seq-4.10.0-1.fc18.x86_64.rpm MUMPS-4.10.0-1.fc18.x86_64.rpm MUMPS-devel.x86_64: W: no-documentation MUMPS.src: W: invalid-url Source1: mumps-extra.tar.gz MUMPS-debuginfo.x86_64: E: debuginfo-without-sources MUMPS-seq.x86_64: W: no-documentation MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/ssimpletest MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libpord-4.10.0.so exit@GLIBC_2.2.5 MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/zsimpletest MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libmumps_common-4.10.0.so exit@GLIBC_2.2.5 MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/csimpletest MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/dsimpletest 5 packages and 0 specfiles checked; 1 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint MUMPS-seq MUMPS-debuginfo MUMPS-devel MUMPS MUMPS-seq.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmpiseq-4.10.0.so /lib64/libm.so.6 MUMPS-seq.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmpiseq-4.10.0.so /lib64/libgcc_s.so.1 MUMPS-seq.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmpiseq-4.10.0.so /lib64/libquadmath.so.0 MUMPS-seq.x86_64: W: no-documentation MUMPS-debuginfo.x86_64: E: debuginfo-without-sources MUMPS-devel.x86_64: W: no-documentation MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/ssimpletest MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libmpi_f77.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libmpi.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libopen-rte.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libopen-pal.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libscalapack.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libmpiblacs.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libmpiblacsF77init.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so libmpiblacsCinit.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so /lib64/libpord-4.10.0.so MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so /lib64/libgcc_s.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcmumps-4.10.0.so /lib64/libquadmath.so.0 MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libpord-4.10.0.so exit@GLIBC_2.2.5 MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/zsimpletest MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmumps_common-4.10.0.so /lib64/libgcc_s.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmumps_common-4.10.0.so /lib64/libquadmath.so.0 MUMPS.x86_64: W: shared-lib-calls-exit /usr/lib64/libmumps_common-4.10.0.so exit@GLIBC_2.2.5 MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/csimpletest MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libmpi_f77.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libmpi.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libopen-rte.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libopen-pal.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libscalapack.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libmpiblacs.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libmpiblacsF77init.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so libmpiblacsCinit.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so /lib64/libpord-4.10.0.so MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so /lib64/libgcc_s.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdmumps-4.10.0.so /lib64/libquadmath.so.0 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libmpi_f77.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libmpi.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libopen-rte.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libopen-pal.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libscalapack.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libmpiblacs.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libmpiblacsF77init.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so libmpiblacsCinit.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so /lib64/libpord-4.10.0.so MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so /lib64/libgcc_s.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzmumps-4.10.0.so /lib64/libquadmath.so.0 MUMPS.x86_64: W: unstripped-binary-or-object /usr/lib64/MUMPS/dsimpletest MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libmpi_f77.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libmpi.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libopen-rte.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libopen-pal.so.4 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libscalapack.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libmpiblacs.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libmpiblacsF77init.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so libmpiblacsCinit.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so /usr/lib64/atlas/liblapack.so.3 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so /lib64/libpord-4.10.0.so MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so /lib64/libgcc_s.so.1 MUMPS.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsmumps-4.10.0.so /lib64/libquadmath.so.0 4 packages and 0 specfiles checked; 1 errors, 61 warnings. # echo 'rpmlint-done:' Requires -------- MUMPS-devel-4.10.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig MUMPS = 4.10.0-1.fc18 MUMPS-debuginfo-4.10.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): MUMPS-seq-4.10.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) libm.so.6()(64bit) libquadmath.so.0()(64bit) rtld(GNU_HASH) MUMPS-4.10.0-1.fc18.x86_64.rpm (rpmlib, GLIBC filtered): /sbin/ldconfig libblas.so.3()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgfortran.so.3()(64bit) libgfortran.so.3(GFORTRAN_1.0)(64bit) libgfortran.so.3(GFORTRAN_1.4)(64bit) liblapack.so.3()(64bit) libm.so.6()(64bit) libmpi.so.1()(64bit) libmpi_f77.so.1()(64bit) libmpiblacs.so.1()(64bit) libmpiblacsCinit.so.1()(64bit) libmpiblacsF77init.so.1()(64bit) libmumps_common-4.10.0.so()(64bit) libpord-4.10.0.so()(64bit) libpthread.so.0()(64bit) libquadmath.so.0()(64bit) libscalapack.so.1()(64bit) rtld(GNU_HASH) Provides -------- MUMPS-devel-4.10.0-1.fc18.x86_64.rpm: MUMPS-devel = 4.10.0-1.fc18 MUMPS-devel(x86-64) = 4.10.0-1.fc18 MUMPS-debuginfo-4.10.0-1.fc18.x86_64.rpm: MUMPS-debuginfo = 4.10.0-1.fc18 MUMPS-debuginfo(x86-64) = 4.10.0-1.fc18 MUMPS-seq-4.10.0-1.fc18.x86_64.rpm: MUMPS-seq = 4.10.0-1.fc18 MUMPS-seq(x86-64) = 4.10.0-1.fc18 libmpiseq-4.10.0.so()(64bit) MUMPS-4.10.0-1.fc18.x86_64.rpm: MUMPS = 4.10.0-1.fc18 MUMPS(x86-64) = 4.10.0-1.fc18 libcmumps-4.10.0.so()(64bit) libdmumps-4.10.0.so()(64bit) libmumps_common-4.10.0.so()(64bit) libpord-4.10.0.so()(64bit) libsmumps-4.10.0.so()(64bit) libzmumps-4.10.0.so()(64bit) Unversioned so-files -------------------- MUMPS-seq-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libmpiseq-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libcmumps-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libcmumps.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libdmumps-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libdmumps.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libmumps_common-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libmumps_common.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libpord-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libpord.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libsmumps-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libsmumps.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libzmumps-4.10.0.so MUMPS-4.10.0-1.fc18.x86_64.rpm: /usr/lib64/libzmumps.so MD5-sum check ------------- http://mumps.enseeiht.fr/MUMPS_4.10.0.tar.gz : CHECKSUM(SHA256) this package : d0f86f91a74c51a17a2ff1be9c9cee2338976f13a6d00896ba5b43a5ca05d933 CHECKSUM(SHA256) upstream package : d0f86f91a74c51a17a2ff1be9c9cee2338976f13a6d00896ba5b43a5ca05d933 Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -v -m fedora-18-x86_64 -b 913152 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AkfG6nASOk&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review