Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> --- For this review, I've focused on: | SHOULD: The reviewer should test that the package functions as described. | A package should not segfault instead of running, for example. * I've installed and configured claws-mail-plugins-bsfilter and noticed that one can crash the plugin when configuring it sloppily: http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2878 * I've built and installed bsfilter, which requires no configuration. * When run within Claws Mail, bsfilter is redirected to --homedir ~/.claws-mail however, whereas when running it outside Claws Mail, it defaults to ~/.bsfilter. Hence I've set a link from ~/.bsfilter to ~/.claws-mail. Just taking a note of it here, this is unrelated to the packaging. ;-) * I've edited my procmail setup to include two recipes from "bsfilter --help" (which is sort of a full manual page, btw, rather than ordinary --help output). With that setup, bsfilter here _works for me_ and meanwhile has started marking Spam messages. [...] The packaging looks sane. In particular, license GPLv2+ matches the preamble of the bsfilter script. The "/usr/bin/env ruby" in the script could be replaced with a hardcoded /usr/bin/ruby: https://fedoraproject.org/wiki/Packaging:Ruby#Shebang_lines | | All other code should use #!/usr/bin/ruby. The rpmlint W/E are commented on in the spec file already: $ rpmlint bsfilter-1.0.18-0.2.rc4.fc.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint bsfilter-1.0.18-0.2.rc4.fc19.noarch.rpm bsfilter.noarch: E: incorrect-fsf-address /usr/bin/bsfilter bsfilter.noarch: E: incorrect-fsf-address /usr/share/doc/bsfilter-1.0.18/COPYING bsfilter.noarch: W: no-manual-page-for-binary bsfilter 1 packages and 0 specfiles checked; 2 errors, 1 warnings. The %check section uses "|| :" and comments on it as a TODO item. Of course, this could mean that although bsfilter _seems to work_ here, some of its features may depend on stuff that also makes the few tests fail. https://fedoraproject.org/wiki/Packaging:Ruby#Running_test_suites APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=not5Rpxndq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review