Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851683 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erik-fedora@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- Taking for review The %global mingw_build_winXX lines can be removed as they're already enabled by default in mingw-filesystem The config.cache files which you use in the src.rpm shouldn't be necessary on Fedora. If building the libraries for the win64 target fails then it is probably caused by an outdated bundled libtool. In that case a BuildRequires: autoconf automake libtool and a 'autoreconf --install --force' in the %prep section should do the trick Is overriding the PATH before the %mingw_configure call still necessary? Is the export ORBIT_IDL really necessary? The orbit2 package isn't mentioned as a BuildRequires In the %mingw_configure call you used '--with-gtk=3.0' while there's only a BuildRequires: mingw32-gtk2 mingw64-gtk2 mentioned earlier in the .spec file. Shouldn't the BuildRequires point to gtk3? The %files section contains several unowned-folders, for example %{mingw32_includedir}/gconf, %{mingw32_includedir}/gconf/2, %{mingw32_libdir}/GConf, %{mingw32_libdir}/GConf/2 and %{mingw32_datadir}/sgml/gconf. You can use the RPM directive %dir to have these folders owned by this package The folders %{mingw32_datadir}/dbus-1, %{mingw32_datadir}/dbus-1/services, %{mingw64_datadir}/dbus-1 and %{mingw64_datadir}/dbus-1/services should be owned by the mingw-dbus package, but that isn't the case yet. A bug report should be filed for the mingw-dbus package so that the package maintainer of mingw-dbus can add those directory ownerships The man-pages should be removed from this package as they duplicate the native dbus man pages. The sgml file also looks like a potential candidate to remove. The autostart files can be removed as well as this feature doesn't work on win32/win64 environments The folders %{mingw32_datadir}/locale and %{mingw64_datadir}/locale should NOT be owned by this package. Please use the %mingw_find_lang macro instead (see the packaging guidelines for an example how to use this) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KahcNbZ0m0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review