Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851677 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flags|fedora-review? | Flags| |fedora-review+ --- Comment #8 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-dbus-glib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-dbus-glib-0.100-4.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-dbus-glib-0.100-4.fc18.noarch.rpm mingw32-dbus-glib-static-0.100-4.fc18.noarch.rpm mingw64-dbus-glib-0.100-4.fc18.noarch.rpm mingw64-dbus-glib-static-0.100-4.fc18.noarch.rpm mingw32-dbus-glib-static.noarch: W: no-documentation mingw64-dbus-glib-static.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpm --query --requires mingw32-dbus-glib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(kernel32.dll) mingw32(libdbus-1-3.dll) mingw32(libdbus-glib-1-2.dll) mingw32(libexpat-1.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libgio-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-dbus-glib-static mingw32-dbus-glib = 0.100-4.fc18 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-dbus-glib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(kernel32.dll) mingw64(libdbus-1-3.dll) mingw64(libdbus-glib-1-2.dll) mingw64(libexpat-1.dll) mingw64(libgio-2.0-0.dll) mingw64(libglib-2.0-0.dll) mingw64(libgobject-2.0-0.dll) mingw64(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-dbus-glib-static mingw64-dbus-glib = 0.100-4.fc18 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-dbus-glib mingw32-dbus-glib = 0.100-4.fc18 mingw32(libdbus-glib-1-2.dll) $ rpm --query --provides mingw32-dbus-glib-static mingw32-dbus-glib-static = 0.100-4.fc18 $ rpm --query --provides mingw64-dbus-glib mingw64-dbus-glib = 0.100-4.fc18 mingw64(libdbus-glib-1-2.dll) $ rpm --query --provides mingw64-dbus-glib-static mingw64-dbus-glib-static = 0.100-4.fc18 $ wget --quiet http://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.100.tar.gz -O - | md5sum d33959a9c0c6a158f5ac6d640316e89e - $ md5sum dbus-glib-0.100.tar.gz d33959a9c0c6a158f5ac6d640316e89e dbus-glib-0.100.tar.gz + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [!] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal The rpmlint warnings for the -static subpackages are harmless and can be ignored The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. This may be caused by the fact that I'm already using mingw-gcc 4.8 here (which uses SEH exceptions instead of SjLj exceptions for the win64 target by default). We can investigate this later, but it isn't a show-stopper for now ===================================================== The package mingw-dbus-glib is APPROVED by epienbro ===================================================== -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3kj78uAClM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review