[Bug 901365] Review Request: python-mongoengine - MongoEngine is an ORM-like layer on top of PyMongo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901365

--- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi Yohan, the installation of python-mongoengine fails, Why?

Your "Requires" apparently are incorrect

Note that :
Requires: pymongo => 2.11
not currently available in fedora. Let's review

if you run the command 
yum --noplugins  provides pymongo
We have the output 

pymongo-2.1.1-2.fc18.x86_64 : Python driver for MongoDB
Repo        : fedora



python-pymongo-2.3-5.fc18.x86_64 : Python driver for MongoDB
Repo        : fedora
Matched from:
Provides    : pymongo = 2.3-5.fc18



python-pymongo-2.3-5.fc18.x86_64 : Python driver for MongoDB
Repo        : @fedora
Matched from:
Provides    : pymongo = 2.3-5.fc18

The version available is 2.1.1, and since in its spec is greater than 2.11
(What makes me think this is a typo), the correct BR should be 
python-pymongo

You should also take a look at this bug [1]

- Become familiar with the code of your package, check import statements,
this will help you know what are the dependencies for the package

- It's good idea make a scratch build on koji before submitting any package to
bugzilla and put the link in the review, this makes it easier to review for a
willing sponsor [2]

- Btw, don't install the documentation available in your package directly,
should generate. use python-sphinx as BR for it


- Although you present the test as a link in the review, I see no section
%check in the spec, please run the available tests

- Please bump the release number every time you make a change in the spec [3]

[1] bug 880372
[2] https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
[3] https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

Kind Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XqYReG2XAi&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]