[Bug 895541] Review Request: ptbl - Periodic Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #15 from RudraB <rudra.banerjee@xxxxxxxxx> ---
Michael Schwendt,
Thanks for your detailed review.

>$ rpmlint -i ./ptbl-1.0-1.fc18.src.rpm 
>ptbl.src: W: strange-permission ptbl-1.0.tar.gz 0600L
>A file that you listed to include in your package has strange permissions.
>Usually, a file should have 0644 permissions.

This issue is discussed in detail in #fedora-devel and it is suggested that
this will be automatically corrected in final update in fedora. So, probably I
can ignore this for the time being. Please comment.

>ptbl.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)
>The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
>annoyance.  Use either spaces or tabs for indentation, not both.
Its probably more to do with style, but I will surely make it coherent in the
next update(I have to write the man page, see below).

$ rpmlint -i ./ptbl-1.0-1.fc18.x86_64.rpm 
>ptbl.x86_64: W: incoherent-version-in-changelog 1.0-6 ['1.0-1.fc18', '1.0-1']
>The latest entry in %changelog contains a version identifier that is not
>coherent with the epoch:version-release tuple of the package.
I will change that accordingly

>ptbl.x86_64: E: zero-length /usr/share/doc/ptbl-1.0/AUTHORS
Will remove it
>ptbl.x86_64: W: no-manual-page-for-binary ptbl
>Each executable in standard binary directories should have a man page.
Will try to write the man page today and tomorrow. Please allow me some time.

>1 packages and 0 specfiles checked; 1 errors, 2 warnings.

I have already edited the image file path. 
After the man page is done and an svg as icon (I already have a .desktop file),
I will resubmit the spec and srpm. 
Or please let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PID6ggEbwX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]