[Bug 895541] Review Request: ptbl - Periodic Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #14 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> $ rpmlint  ./ptbl.spec ../SRPMS/ptbl-1.0-1.fc18.src.rpm 
> ptbl.src: W: no-version-in-last-changelog
> ptbl.src: W: strange-permission ptbl-1.0.tar.gz 0600L
> 1 packages and 1 specfiles checked; 0 errors, 2 warnings.
>  is the warning I am getting!

Run "rpmlint -i" on _all_ rpms, the src.rpm _and_ all built rpms. The -i option
will help you. Else ask.


I've downloaded the src.rpm from the koji scratch build, then used
rpmdev-extract to examine its contents:

* I agree with comment 8.


> BuildRequires:  rarian-compat   

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Scrollkeeper

I wonder why it uses scrollkeeper and runs no-op commands like
scrollkeeper-update?


> %description
> Periodic Table application 

A few more words would be good. Not to explain what a periodic table is, but
what the application can do. I mean, currently the %summary is even longer than
the %descripton, and the description on your web page is better, too. ;)

https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description


> /usr/bin/ptbl

https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files


> %{_datadir}/images

That's an odd location for an application's images. Shouldn't it create its
very own subdirectory as /usr/share/ptbl/images instead? The FHS suggests that.

$ repoquery --whatprovides /usr/share/images
linphone-mediastreamer-0:3.5.2-5.fc18.x86_64
linphone-0:3.5.2-4.fc18.x86_64
linphone-mediastreamer-0:3.5.2-5.fc18.i686
linphone-0:3.5.2-4.fc18.i686
 -> bug 896735

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ywrYdlFXjC&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]