Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895541 --- Comment #16 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > This issue is discussed in detail in #fedora-devel and it > is suggested that this will be automatically corrected in > final update in fedora. No, please fix it during review. In particular since you will need to build an updated src.rpm anyway. You need to understand that warning, and it is very easy to fix this rather harmless one with a "chmod 0644 ptbl-1.0.tar.gz" prior to building the src.rpm. It is nothing that will be corrected "automatically", because you need to give files inside the src.rpm (and later in Fedora dist git, where this is much more important) proper default ownership and permissions. > Will try to write the man page today and tomorrow. Do notice that rpmlint says "SHOULD" and not "MUST. The review guidelines say: | SHOULD: your package should contain man pages for binaries/scripts. | If it doesn't, work with upstream to add them where they make sense. "Where they make sense" may be an important part here. Unless you plan to add lots of command-line options to ptbl, its man page probably won't explain more than that ptbl is a graphical app and repeating a brief description and license information. That won't be very helpful. Especially not on an RPM based platform, where one can examine files also via their packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qlEhvj3PzU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review