Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891194 --- Comment #3 from Michael Scherer <misc@xxxxxxxx> --- > Tests aren't currently run due on most Node.js modules to the lack of the TAP > testing framework being packaged for Fedora. I didn't found nodejs-tap, but I thought this was because it was in bundle of nodejs-devel. I do not want to block on it, but given the number of packages, it is IMHO easier to do it right now, than go back later and enable it on every packages. > Do we really have to kill off the EL5isms just yet? For EL5ism, I am in the camp of those thinking that we should start to clean now if we want to get ride of them in 2020, rather than starting to get ride once EL5 is really dead in 2020. I will not fight for this ( especially since packagers can perfectly add them back later after the review ), but I would really prefer to have people submitting packages for rawhide to be as warning free as possible on fedora-review, based on the current rawhide. Each time spent cleaning the report of f-r is time not spend on others packages review. And each subtlity added is adding to the work of review, and I think we should simplify and enforce the best practice. > Pure-JavaScript Node modules are installed in /usr/lib, consistent with both > upstream and other interpreted languages in the distribution (such as Python > and Ruby). Ruby place gems in /usr/share/, and python should permit to use /usr/share for python 3.3 ( IIRC what a upstream told me a few months ago ). In fact, we have here a conflict between "follow the FHS" and "follow upstream", but I do not think this is the place or time to solve it, so for now, let's follow upstream. I think however that suggesting to upstream to support the FHS would be nice ( ie, support /usr/lib and /usr/share ). I guess once a node-sig is created, that would be a nice starter for discussion :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W5MBJNbAoF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review