Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891194 --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #1) > Package Review Thanks for taking this! > Issues: > ======= > - non regression tests should be run Tests aren't currently run due on most Node.js modules to the lack of the TAP testing framework being packaged for Fedora. (That's next on my to-do list.) If you want this to be a review blocker we'd have to get that and its dep chain into Fedora first. Otherwise I intend to enable %check for all the modules I can as soon as its in, and some specs already have commented out sections ready to go. > - no need for BuildRoot, %clean, etc Do we really have to kill off the EL5isms just yet? I haven't entirely discounted supporting EL5 and I traditionally supported it when I was maintaining my own repo. I might add that I used the 'minimal' spec template from rpmdev-newspec as a starting point for the spec template for my npm2rpm tool, and that still includes these constructs. Also, I don't get why fedora-review makes this a MUST item, as the Fedora Packaging Guidelines still specifically *permit* these constructs in modern Fedora packages for those of us who want to maintain spec compatibility with EL5. > > Rpmlint > ------- > Checking: nodejs-graceful-fs-1.1.14-1.fc19.noarch.rpm > nodejs-graceful-fs.noarch: W: spelling-error %description -l en_US js -> > dis, ks, j False positive, used in "Node.js". > nodejs-graceful-fs.noarch: W: only-non-binary-in-usr-lib Pure-JavaScript Node modules are installed in /usr/lib, consistent with both upstream and other interpreted languages in the distribution (such as Python and Ruby). > 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rMcgR6WhU3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review