Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891238 --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #1) > Hi, > > so first, nice to have npm deps being in place in rpm, much easier :) Absolutely! Maintaining the deps manually back in the day was a nightmare. > A few notes : > > 1) %defattr(-,root,root,-) > BuildRoot, > and cleaning of root before %install > and %clean > > are not needed, can you remove them ? As discussed in bug 891194 I'd like to keep these for now if that's okay. > 2) %check is not used ( this would need a few package, tap and rimram, both > added as deps on this bugs ) Okay, I'll package the TAP stack soon then. > 3) could the summary be improved a little :) Sure, I got kinda lazy with some of them and just left the npm registry summary/description. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SUOJaXJegH&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review