Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823337 --- Comment #14 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Cool. Thank you for the patches. I hope they'll get accepted soon. Just cannot resist, have you tested it on F18+? Since /tmp is now TmpFs, I hope it will not cause another troubles ;) And few other notes: * Mark patches as Patch0 and Patch1 - I'd love to see the patches marked as Patch0, Patch1 instead of Source2, Source3. I don't think where will be any difference in the end, but it feels better to me. * %exclude %{gem_instdir}/spec should not be needed - If I am not mistaken, this line is not needed, since you expand the test suite after the %install section is done, so there is no chance that it could appear in %{buildroot} @David: Any other comments? Will you finish the review or should I? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d6aIfYdM2w&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review