Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823337 --- Comment #15 from Julian C. Dunn <jdunn@xxxxxxxxxxxx> --- (In reply to comment #14) > Cool. Thank you for the patches. I hope they'll get accepted soon. > > Just cannot resist, have you tested it on F18+? Since /tmp is now TmpFs, I > hope it will not cause another troubles ;) Yes, I tested my patches on a F18-beta VM. > And few other notes: > > * Mark patches as Patch0 and Patch1 > - I'd love to see the patches marked as Patch0, Patch1 instead of Source2, > Source3. I don't think where will be any difference in the end, but it > feels > better to me. That makes sense. > * %exclude %{gem_instdir}/spec should not be needed > - If I am not mistaken, this line is not needed, since you expand the test > suite after the %install section is done, so there is no chance that it > could appear in %{buildroot} Correct. The above problems have been fixed and SPEC/SRPM have been updated. http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout.spec http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout-1.1.0-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vawJuSub7N&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review