Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 --- Comment #4 from Fabian Deutsch <fdeutsch@xxxxxxxxxx> --- Hey Matthias, the main issue is see is the (possible) bundling of cssmin.js. To me it's not obvious if it's just bundling or a fork of cssmin.js. Please clarify this with upstream and note it in the spec. Now that we've come to the end of this lengthy review, it's time to say that you should also add the LICENSE file to %doc. - fabian Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Package contains no bundled libraries. It seems as i cssmin.js is a modified copy or fork of https://github.com/stoyan/yuicompressor/blob/master/ports/js/cssmin.js https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. LICENSE is missing from %doc, you could also add README.md [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: Requires correct, justified where necessary. Might need an update if cssmin.js is an extra package. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: Package contains no bundled libraries. It seems as i cssmin.js is a modified copy or fork of https://github.com/stoyan/yuicompressor/blob/master/ports/js/cssmin.js [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [-]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. LICENSE is missingfrom %doc, you could also add README.md [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [-]: Package is not relocatable. [!]: Requires correct, justified where necessary. Might need an update if cssmin.js is an extra package. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (less.js-1.3.1.tar.gz) [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: lessjs-1.3.1-2.fc19.src.rpm lessjs-1.3.1-2.fc19.noarch.rpm lessjs.src: W: spelling-error Summary(en_US) js -> dis, ks, j lessjs.src: W: spelling-error Summary(en_US) stylesheet -> style sheet, style-sheet, stylishness lessjs.src: W: spelling-error %description -l en_US mixins -> mixing, mix ins, mix-ins lessjs.src: W: spelling-error %description -l en_US js -> dis, ks, j lessjs.src:12: W: macro-in-comment %{version} lessjs.src: W: invalid-url Source0: less.js-1.3.1.tar.gz lessjs.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j lessjs.noarch: W: spelling-error Summary(en_US) stylesheet -> style sheet, style-sheet, stylishness lessjs.noarch: W: spelling-error %description -l en_US mixins -> mixing, mix ins, mix-ins lessjs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j lessjs.noarch: W: no-documentation lessjs.noarch: W: no-manual-page-for-binary lessc 2 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint lessjs lessjs.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j lessjs.noarch: W: spelling-error Summary(en_US) stylesheet -> style sheet, style-sheet, stylishness lessjs.noarch: W: spelling-error %description -l en_US mixins -> mixing, mix ins, mix-ins lessjs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j lessjs.noarch: W: no-documentation lessjs.noarch: W: no-manual-page-for-binary lessc 1 packages and 0 specfiles checked; 0 errors, 6 warnings. # echo 'rpmlint-done:' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iQidhvl8AK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review