Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #7 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- (In reply to comment #6) > > * Enabling test suite > > - As this package contains test/ directory, please execute > > some tests in %check (like ruby -Ilib test/test_inifile.rb) > > Their tests require a separate gem be installed called bones. I would prefer > not to package that as it's not useful to me and isn't a runtime requirement > for inifile. - That is needed when you try to execute test suite using rake (bones is used only in Rakefile). See: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites the line "The tests should not be run using Rake". As I said before, it seems that "ruby -Ilib test/test_inifile.rb" does some test program, so please consider to enable %check section. > > * Documentation > > - Current ruby guideline says test/ directory should not be > > shipped in binary rpm > > > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > > Ruby#Running_test_suites > > Hrm, that should be in the -doc package. Looking in the packages built the > test directory is with the docs, per the specfile. - So the current guideline says test/ directory should not be included also in -doc subpackage (see "Do not ship tests" in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites ) (If you think test/ directory in this gem is useful for users, I won't treat this as a blocker) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lq1fnX9eAu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review